bug - missing dr names

Reported on 3/1/22

background

Right after 1.98 release, reports of dr names not showing up on calendar view came in.

root

Employee.php model had $keyType=’string’; added as a property to allow for media loading. The primary key is integer, but the model_id in the media table for handling polymorphic joins is a varchar. This had worked in the past, but the behaviour changed in the last week for unknown reason. Belief is that the media-library package may have had a small incremental version bump during an upgrade and is now more serious about types. The root problem is a postgresql SQL error coming back though.

fix

Spots in the shift-related JS that compare a given employee_id to the list of employee_ids in the client code are now forced in to .toString() comparisons. There may have been a somewhat easier way.

possibly - ScheduleController line 195… $employees = (new EmployeeRepository())->all()->map(function ($e) { $e->id = (int) $e->id; return $e; });

However, I can’t get on prod server to verify at this time…