Skip to content

bug - clock in/out issue

Reported on ¼/22

background

Dr Koh could not log out of Jan 3 shift. The user had not manually clocked in - the clock in was manually entered in admin timesheet.

The shiftService::canUserClockOut checks methods _isShiftClockedIn and _isShiftClockedOut. These were checking if a manual timesheet override existed, but the check was looking for ‘count>1’ but should have been count>0 (or ideally count===0).

test

test testShiftClockInAndOutOverridden() was added to exercise only checking manual admin timesheet entries and checking the canClockIn and canClockOut status values.